Add DDA for drawing lines? #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey, thanks for opening this PR! Do you have a before/after images you can share of what it looks like using this? Also this PR is adding the function but not actually using it to draw, is that intentional? |
1. Replace `DDA_round` with builtin function `round` and `max` 2. Describe the procedure with comments
Author
|
The screenshot below shows the difference between the result of original and my I have to admit that the aliasing is quite unnoticeable owing to the high-resolution LCD screen.
Comparison using the The original method
Please see the latest update of the PR. I have made some changes to improve the quality of the code. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original function
draw_linemay create some artifacts during rasterization. I would like to add the DDA algorithm because it's simple and easy to understand.